feat: initial implementation for WebM player for recordings #832
Conversation
webapp/player/index.html
Outdated
| <head> | ||
| <meta name="viewport" content="width=device-width"> | ||
| <link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/xterm-player@latest/dist/css/xterm-player.min.css" /> | ||
| <script src="https://cdn.jsdelivr.net/npm/xterm@4.4.0/lib/xterm.min.js"></script> |
There was a problem hiding this comment.
@nicolesabourin1 I'm not sure how we currently handle the dependencies for the rest of our web frontend, but we'd need to build and include external dependencies alongside the rest of the frontend such that it can work without Internet access. No external CDN delivery can be used for this, as this causes problems for GDPR compliance in addition to breaking things when used without Internet access
There was a problem hiding this comment.
My understanding is that we should use the @xterm/xterm npm package: https://www.npmjs.com/package/@xterm/xterm
It’s then possible to use ES6 module syntax:
import { Terminal } from '@xterm/xterm';Can you confirm? @kristahouse
There was a problem hiding this comment.
Yes, you can use ES6 module syntax to import modules in a plain JavaScript setup within an HTML page.
There was a problem hiding this comment.
how quickly can this be fixed? we're looking into making a new release soon, and it would be great to have a V1 of the web player included in it
There was a problem hiding this comment.
The problem here is we need a way to host the static web files inside the gateway web server for the xterm js and css files, just like we did for the webapp static files, but in this case the webapp may not be enabled, @CBenoit will need to make an endpoint for the static files.
There was a problem hiding this comment.
@pauldumais Just like for the webapp, the GET /jet/jrec/play/* endpoint is serving all the files found in the player/ folder. Is it not enough in this case? It’s working really the same as the GET /jet/webapp/client/* endpoint.
There was a problem hiding this comment.
@CBenoit awesome, I just added the xterm player files locally to the folder
| req.send(null); | ||
| } | ||
|
|
||
| function convertTRPtoCast(fileArray) { |
There was a problem hiding this comment.
we have our answer, Paul baked in a live TRP to .cast converter directly in the Javascript of the player, so it'll be able to play the older TRP file format as well :)
CBenoit
changed the title
Adds a video and xterm player at the
GET /jet/jrec/playendpoint which supports multiple videos and builds the page dynamically based on the type of recording.Issue: DGW-110